Incorrect maximum sizes?
Concern
I think the MAX_ values are being filled in with the HC sizes for all situations in this code here: https://gitlab.hax0rbana.org/signet/signet-base/-/blob/trunk/signetdev/common/signetdev_common_priv.h?ref_type=heads#L52
It looks like they have a conditional which has both sides hard coded. The RAW_HID_PACKET_SIZE
values can not be used, as they only exist when FIRMWARE is defined. However, we can use #ifdev SIGNET_HC
and #else
for the original Signet.
Impact
How can we confirm that these values are incorrect? What problems will it cause? How can we test?